-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: bitVec shiftLeft recurrences for bitblasting #4571
Merged
kim-em
merged 51 commits into
leanprover:master
from
opencompl:upstream-shiftLeft-recurrence
Jul 27, 2024
Merged
feat: bitVec shiftLeft recurrences for bitblasting #4571
kim-em
merged 51 commits into
leanprover:master
from
opencompl:upstream-shiftLeft-recurrence
Jul 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mathlib CI status (docs):
|
kim-em
reviewed
Jun 28, 2024
kim-em
reviewed
Jun 28, 2024
kim-em
reviewed
Jun 28, 2024
We rebase over f16515b.
f16515b
to
640df34
Compare
alexkeizer
reviewed
Jul 3, 2024
Co-authored-by: Alex Keizer <[email protected]>
Co-authored-by: Alex Keizer <[email protected]>
AtticusKuhn
reviewed
Jul 24, 2024
AtticusKuhn
reviewed
Jul 24, 2024
AtticusKuhn
reviewed
Jul 24, 2024
AtticusKuhn
reviewed
Jul 24, 2024
awaiting-review |
alexkeizer
reviewed
Jul 26, 2024
kim-em
reviewed
Jul 26, 2024
src/Init/Data/BitVec/Bitblast.lean
Outdated
/-- | ||
If `x &&& y = 0`, then addition does not overflow, and thus `(x + y).toNat = x.toNat + y.toNat`. | ||
-/ | ||
theorem toNat_add_eq_toNat_add_toNat_of_and_eq_zero {x y : BitVec w} (h : x &&& y = 0#w) : |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
toNat_add_of_and_eq_zero
will suffice: if there's only one sensible RHS, it doesn't need to be described in the name.
kim-em
reviewed
Jul 26, 2024
kim-em
reviewed
Jul 26, 2024
Besides the renamings, and Alex's comment suggestion this now looks good to go! |
Co-authored-by: Kim Morrison <[email protected]>
Co-authored-by: Kim Morrison <[email protected]>
Co-authored-by: Alex Keizer <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 7, 2024
We follow the same strategy as #4872, #4571, and implement bitblasting theorems for `sshiftRight`. --------- Co-authored-by: Tobias Grosser <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
awaiting-review
Waiting for someone to review the PR
toolchain-available
A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These theorems are used for bitblasting shiftLeft in LeanSAT.