chore: add more trace nodes, for better profiling data #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexkeizer
force-pushed
the
better-tracing
branch
from
da1990c to
6aca323
Compare
This was referenced Oct 2, 2024
alexkeizer
changed the title
alexkeizer
force-pushed
the
better-tracing
branch
3 times, most recently
from
ffced42 to
21657ae
Compare
alexkeizer
force-pushed
the
better-tracing
branch
from
21657ae to
6831720
Compare
|
@shigoel rebased on main, this is now ready for review |
|
Also, I cherry-picked the changes from #214 onto this PR, to reduce the amount of open PRs |
shigoel
reviewed
Oct 8, 2024
shigoel
reviewed
Oct 8, 2024
shigoel
reviewed
Oct 8, 2024
shigoel
reviewed
Oct 8, 2024
shigoel
approved these changes
Oct 8, 2024
shigoel
added a commit
that referenced
this pull request
Oct 8, 2024
…ep in `sym_n` (#213) ### Description: Stacked on: - [x] #204 - [x] #207 - [x] #209 - [x] #211 This PR implements "snorkeling" of the heartbeat budget. This unfortunately does not buy us much, as aggregation for 500 steps already seems to hit both the recursion limit and heartbeat budget, by itself. ### Testing: What tests have been run? Did `make all` succeed for your changes? Was conformance testing successful on an Aarch64 machine? Yes ### License: By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Co-authored-by: Shilpi Goel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Stacked on:
Testing:
What tests have been run? Did
make allsucceed for your changes? Wasconformance testing successful on an Aarch64 machine? Yes
License:
By submitting this pull request, I confirm that my contribution is
made under the terms of the Apache 2.0 license.