feat(specialize): additional goals come after the main goal #777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The alternative, I guess would be to see if we can change the Lean 4 behaviour. The required diff in mathlib is at https://github.com/leanprover-community/mathlib/compare/revert_530. |
|
The order was requested by Kevin: https://leanprover.zulipchat.com/#narrow/stream/217875-Is-there-code-for-X.3F/topic/specialize.20h.20_.2C.20swap/near/225703117 |
|
The Lean 4 behaviour was changed to match Lean 3 in leanprover/lean4#1796. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts #530.
Lean 4's
specializeputs the additional goals after the main goal. Rather than writing an additional mini-tactic to preserve Lean 3 behaviour, I propose we just backport to achieve this behaviour. It's a relatively minor change to mathlib to adapot.I couldn't find an account of why #530 wanted to change the order in the first place.