Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(init/meta/interative): Change the behaviour of specialize to put goals from underscores first #530

Closed

Conversation

shingtaklam1324
Copy link
Contributor

@shingtaklam1324 shingtaklam1324 commented Feb 11, 2021

@shingtaklam1324
Copy link
Contributor Author

There is also a set of tests at https://github.com/leanprover-community/mathlib/pull/6150/files#diff-bf742064f8ef6e229c0fa7b5df4c4b97b090242eae93579926f970c5856ccaa8 but I'm not sure how the tests work in this repo.

@bryangingechen
Copy link
Collaborator

There's some explanation here, but it should also be fine to let CI tell us what's broken:

bors try

bors bot added a commit that referenced this pull request Feb 11, 2021
@leanprover-community leanprover-community deleted a comment from bors bot Feb 11, 2021
@bors
Copy link

bors bot commented Feb 11, 2021

try

Build failed:

@bryangingechen
Copy link
Collaborator

bors try

bors bot added a commit that referenced this pull request Feb 11, 2021
@shingtaklam1324 shingtaklam1324 changed the title feat(init/meta/interative): Change the behaviour of specialize to put goals from underscores firsts feat(init/meta/interative): Change the behaviour of specialize to put goals from underscores first Feb 11, 2021
@bors
Copy link

bors bot commented Feb 11, 2021

@gebner
Copy link
Member

gebner commented Feb 25, 2021

bors r+

bors bot pushed a commit that referenced this pull request Feb 25, 2021
@bors
Copy link

bors bot commented Feb 25, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(init/meta/interative): Change the behaviour of specialize to put goals from underscores first [Merged by Bors] - feat(init/meta/interative): Change the behaviour of specialize to put goals from underscores first Feb 25, 2021
@bors bors bot closed this Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants