Deprecate Currency::format #1810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sweemer
force-pushed
the
deprecate-format
branch
from
3e8c1b4 to
5abfbf8
Compare
|
@lballabio Can we include this in 1.33? |
|
Yes, one way or the other — I wanted to try and understand what isn't working first |
lballabio
reviewed
Dec 11, 2023
ql/money.hpp
Outdated
| /*! \deprecated Copy the formatting into your project if you need it. | ||
| Deprecated in version 1.33. | ||
| */ | ||
| [[deprecated("Copy the formatting into your project if you need it.")]] |
There was a problem hiding this comment.
I would probably keep operator<< for convenience but just have it output something like rounded value + ISO currency, as in "150 JPY"
sweemer
force-pushed
the
deprecate-format
branch
from
5abfbf8 to
7d1c6b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1801
Let me know if there are any other arguments to the constructors of
CurrencyorCurrency::Datathat you think should be deprecated at the same time.