Inconsistent currency formatting

[sweemer]

I just happen to notice, that the format strings for some currencies are fine (like for EUR), some are wrong (like for EGP), and some result in an exception being thrown (like for NGN).

#include <ql/currencies/all.hpp>
#include <ql/money.hpp>
#include <iostream>

using namespace QuantLib;

int main() {
  Money m1 = 50000.0 * EURCurrency();
  std::cout << m1 << std::endl; // prints "EUR 50000.00"
  Money m2 = 50000.0 * EGPCurrency();
  std::cout << m2 << std::endl; // prints "1$.2f EGP"
  Money m3 = 50000.0 * NGNCurrency();
  std::cout << m3 << std::endl; // throws "boost::bad_format_string: format-string is ill-formed"
}

Is currency formatting still a supported feature? If so, then I guess all the formats should be reviewed and fixed where necessary. If not, then maybe this feature can be deprecated in 1.32 and then removed later.

I'm using clang 18 on Ubuntu 22 but I would imagine that all platforms are equally affected.

[sweemer]

If no consensus, then I propose we deprecate Currency::format and remove it in a later release.

[lballabio]

Sometimes I think we should deprecate the whole Money and Currency classes, but that would be too far 😄

format can probably be deprecated.

[sweemer]

OK I will take a stab at the PR

[github-actions]

This issue was automatically marked as stale because it has been open 60 days with no activity. Remove stale label or comment, or this will be closed in two weeks.