fix : ignore range input to restore default behavior #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -22,6 +22,11 @@ | |||
| break; | |||
| } | |||
|
|
|||
| //ignore range input element | |||
| if (el.nodeName === 'INPUT' && el.hasAttribute('type') && el.getAttribute('type') === 'range') { | |||
There was a problem hiding this comment.
We can safely call getAttribute without checking hasAttribute first, it will return null. I'd remove hasAttribute to avoid another function call.
|
It seems this project still uses tabs for indentation (heh). Can you modify your PR to use tabs as well so the code you added is indented correctly? Thanks! |
|
I think it is all good now. |
|
Looks good, thanks @stity! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #24