Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaks time scrubbing on video tag #19

Open
headsuptechnologies opened this issue Nov 17, 2015 · 4 comments
Open

Breaks time scrubbing on video tag #19

headsuptechnologies opened this issue Nov 17, 2015 · 4 comments

Comments

@headsuptechnologies
Copy link

Time scrubbing/seeking on the built in video controls will not get the touchmove event. Work around is to set the overflow scrolling CSS properties on the video tag's parent, but this still affects the performance of the scrubbing.

@lazd
Copy link
Owner

lazd commented Nov 17, 2015

Very interesting. Maybe we can add an exception when touchstart happens
inside of a video element... Can you create a fiddle that reproduces the
error so I can poke at it?

On Tuesday, November 17, 2015, Jon Jensen [email protected] wrote:

Time scrubbing/seeking on the built in video controls will not get the
touchmove event. Work around is to set the overflow scrolling CSS
properties on the video tag's parent, but this still affects the
performance of the scrubbing.


Reply to this email directly or view it on GitHub
#19.

@lazd
Copy link
Owner

lazd commented Sep 22, 2016

@headsuptechnologies perhaps we need an exception for the <video> element the same way that we have for input[type="range"] (#29). Would that fix the issue?

@hideyuki
Copy link

hideyuki commented Oct 18, 2016

I faced same problem of video and audio tag on iOS safari10.
And I could fix the issue by the same way #29

if ((el.nodeName === 'INPUT' && el.getAttribute('type') === 'range') ||
    el.nodeName === 'VIDEO' || el.nodeName === 'AUDIO') {
    return;
}

@lazd
Copy link
Owner

lazd commented Oct 21, 2016

@hideyuki looks good, please send a pull request for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants