Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed responsiveness of footer. #129

Merged
merged 5 commits into from
Jun 9, 2021
Merged

fixed responsiveness of footer. #129

merged 5 commits into from
Jun 9, 2021

Conversation

Anita-ihuman
Copy link
Contributor

Signed-off-by: Anita-ihuman [email protected]

Description
Fixed the footer to be responsive on mobile and desktop view
This PR fixes #116

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@netlify
Copy link

netlify bot commented Jun 3, 2021 •
edited
Loading

✔️ Website preview ready!

🔨 Explore the source changes: 7185c87

🔍 Inspect the deploy log: https://app.netlify.com/sites/getnighthawk/deploys/60c0d5d65a932f0007521043

😎 Browse the preview: https://deploy-preview-129--getnighthawk.netlify.app

@Anita-ihuman Anita-ihuman requested a review from Grumpyyash June 3, 2021 23:15
@vinayaksh42
Copy link
Member

Changes to the copyright text and social media icons are looking great.
Just one thing regarding the top (logo) section of the footer.
Before:
chrome_SI7tegHWnR
After:
chrome_ypl7S7xqB9

The alignment is a bit off in the after version. The Resources section is not coming right under the Getting Started section

@vinayaksh42 vinayaksh42 mentioned this pull request Jun 4, 2021
Closed
1 task
JubayerJoy
JubayerJoy reviewed Jun 4, 2021
View reviewed changes
Copy link
Member

@JubayerJoy JubayerJoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, just a small change 🚀
Also, please resolve this mixed content issue. Don't know why it's giving an error though, you didn't make any change or used it.

Anyways, Really nice work 🎈

docs/_sass/footer.scss Outdated Show resolved Hide resolved
@Jashpatel1
Copy link
Member

@Anita-ihuman Please fix the conflicts.

@Jashpatel1
Copy link
Member

@Anita-ihuman There are conflicting files present yet. Once you fix them, we are ready to go.

Jashpatel1
Jashpatel1 approved these changes Jun 9, 2021
View reviewed changes
Copy link
Member

@Jashpatel1 Jashpatel1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks @Anita-ihuman

@Jashpatel1 Jashpatel1 merged commit 770117f into layer5io:master Jun 9, 2021
@Jashpatel1 Jashpatel1 mentioned this pull request Jun 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JubayerJoy JubayerJoy JubayerJoy left review comments

@Jashpatel1 Jashpatel1 Jashpatel1 approved these changes

@Grumpyyash Grumpyyash Awaiting requested review from Grumpyyash

@vinayaksh42 vinayaksh42 Awaiting requested review from vinayaksh42

@chinmaym07 chinmaym07 Awaiting requested review from chinmaym07

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Site] Footer re-work and Mobile responsiveness
4 participants
@Anita-ihuman @vinayaksh42 @Jashpatel1 @JubayerJoy