Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Site] Live site needs to match with the design #108

Closed
akashc777 opened this issue May 14, 2021 · 12 comments
Closed

[Site] Live site needs to match with the design #108

akashc777 opened this issue May 14, 2021 · 12 comments
Assignees
Labels
component/ui User Interface

Comments

@akashc777
Copy link
Contributor

Current State of the GetNighthawk.dev site
A brief description of what the problem is.

The background colors, alignment, and spacing doesn't match the design

eg.
Screenshot 2021-05-14 at 5 46 58 AM

Desired State of the GetNighthawk.dev site
A brief description of the change you are requesting.

Matching all the alignments, colors, and spacing with the design https://www.figma.com/file/5ZwEkSJwUPitURD59YHMEN/Layer5-Designs?node-id=5884%3A12909

eg.
Screenshot 2021-05-14 at 5 22 28 AM


Contributor Resources

@akashc777 akashc777 added the component/ui User Interface label May 14, 2021
@welcome
Copy link

welcome bot commented May 14, 2021

Thanks for opening this issue. A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Community Welcome Guide and sure to join the community Slack.

@leecalcote
Copy link
Member

Thanks, @akashc777

@akashc777
Copy link
Contributor Author

Hi @leecalcote ,
I will wait for my previous PR to get merged since it will give me an idea if I need to make some improvements in my coding style or I should follow any best practices. Before making some major changes here 😅.

I will start working on this as soon as my 1st PR gets merged 🕺🏼.

@leecalcote
Copy link
Member

// @austinogiza @vinayaksh42

@vinayaksh42
Copy link
Member

Hey @akashc777 , Your 1st PR has been recently merged. Would you like to work on this issue now?

@akashc777
Copy link
Contributor Author

Thanks @vinayaksh42 for the mention. I got held up with interviews. I will make a PR within 1-2 days from now

@JubayerJoy
Copy link
Member

@akashc777 will not be with us for some time.
Anyone interested can take the issue.

@NikhilSharma03
Copy link
Member

@JubayerJoy Can I work on this??

@JubayerJoy
Copy link
Member

@NikhilSharma03 Sure!
Please check the previous PR of @akashc777 for reusing some of the work done.

@Jashpatel1
Copy link
Member

Any progress here @JubayerJoy @NikhilSharma03

@NikhilSharma03
Copy link
Member

@Jashpatel1 I think this issue was recreated and is in progress by Anita-ihuman. Let me know if I have to work on this issue.
Thank you.

@Jashpatel1
Copy link
Member

Closing with #129

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/ui User Interface
Development

Successfully merging a pull request may close this issue.

6 participants