added mailing list

[akashc777]

Signed-off-by: Akash Hadagali [email protected]

Description

This PR fixes #101

Notes for Reviewers

Signed commits

• Yes, I signed my commits.

[welcome]

Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Community Welcome Guide and sure to join the community Slack.
Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while peforming a commit.

[DelusionalOptimist]

Looks great @akashc777! 🚀
Just some very minor changes :D

[DelusionalOptimist]

The responsive one looks kinda odd 🤔

I don't know much about how UI works so feel free to ignore this if it is not in your control 🙂

[DelusionalOptimist]

Also, you might need to do a rebase. This might be useful for reference.

[akashc777]

@DelusionalOptimist I didn't receive designs for mobile view so didn't make it responsive yet 🙄

[DelusionalOptimist]

@DelusionalOptimist I didn't receive designs for mobile view so didn't make it responsive yet roll_eyes

Oh! My bad. I should have seen it in the issue. 😬

[akashc777]

I need some help with sign-off (sry I'm new to this)
not sure it worked since DCO is still red

[DelusionalOptimist]

Hmm 🤔. Seems like applying suggestions from GitHub itself added Co-authored-by: Rudraksh Pareek <[email protected]> with the commit message instead of your sign off in 189d749 (#107).
Maybe that's why DCO is failing.

[adithyaakrishna]

@akashc777 Could you run these commands, in the same order? I'm not sure they would fix it, but we can try this 👀

• git config --global user.name "Your Name"
• git config --global user.email "Your Email"
• git commit --amend --no-edit --signoff
• git push --force-with-lease origin enhancement/mailing-list_section

[akashc777]

@adithyaakrishna yup... 1st two are I think one-time thing... I did run the last two in the same order

[akashc777]

Hmm 🤔. Seems like applying suggestions from GitHub itself added Co-authored-by: Rudraksh Pareek <[email protected]> with the commit message instead of your sign off in 189d749 (#107).
Maybe that's why DCO is failing.

i think that's the issue

[vinayaksh42]

The mailing list component is merging with the footer. Both the footer and Mailing list components have the same background color. I am not sure if this is part of the design, but it looks odd (suggestions on this @austinogiza).
Also, the space occupied by the component is a bit larger than what we usually have for a mailing list ( for example, on this page https://layer5.io/projects/getnighthawk, both subscribe and cncf 'join us' components are taking a bit less space.)

[adithyaakrishna]

@adithyaakrishna yup... 1st two are I think one-time thing... I did run the last two in the same order

Yeah, it's a one time thing, I thought there was an issue with the config regarding the signoffs
Saw it just now, your first commit is perfectly signedoff 😶

[akashc777]

The mailing list component is merging with the footer. Both the footer and Mailing list components have the same background color. I am not sure if this is part of the design, but it looks odd (suggestions on this @austinogiza).
Also, the space occupied by the component is a bit larger than what we usually have for a mailing list ( for example, on this page https://layer5.io/projects/getnighthawk, both subscribe and cncf 'join us' components are taking a bit less space.)

I followed these designs https://www.figma.com/file/5ZwEkSJwUPitURD59YHMEN/Layer5-Designs?node-id=5884%3A12909
the mailing list buttons are bigger than the join us button I think that's right?

[vinayaksh42]

Do a simple center alignment of all three buttons for the mobile view.

[akashc777]

you mean to remove flex ?

[DelusionalOptimist]

So I'm listing some steps. Follow these to fix the DCO thingy:

• On your branch, do git rebase -i d4c6596
• In the editor that opens, change

pick 189d749 Update docs/_includes/mailing-list.html spelling mistakes

to

reword 189d749 Update docs/_includes/mailing-list.html spelling mistakes

and save

• Another editor will open where you should remove the line that says
  Co-authored-by: Rudraksh Pareek <[email protected]> and save.
• Then you need to do
  git commit --amend -s and save and quit. This should sign off this commit
• Check if your changes are alright and the history looks aligned.
• Force push to update changes here

Free tip, if you see vim :w to save :q to quit.

[vinayaksh42]

Try to follow this guide https://github.com/layer5io/layer5/blob/master/CONTRIBUTING.md#signing-off-on-commits-developer-certificate-of-origin for DCO issue

[akashc777]

So I'm listing some steps. Follow these to fix the DCO thingy:

• On your branch, do git rebase -i d4c6596
• In the editor that opens, change

pick 189d749 Update docs/_includes/mailing-list.html spelling mistakes

to

reword 189d749 Update docs/_includes/mailing-list.html spelling mistakes

and save

• Another editor will open where you should remove the line that says
  Co-authored-by: Rudraksh Pareek <[email protected]> and save.
• Then you need to do
  git commit --amend -s and save and quit. This should sign off this commit
• Check if your changes are alright and the history looks aligned.
• Force push to update changes here

Free tip, if you see vim :w to save :q to quit.

Thanks a lot !
Now I'm not gonna use GitHub for future commits

[akashc777]

@DelusionalOptimist @vinayaksh42 made it responsive for mobile please have a look

[DelusionalOptimist]

This looks all good to me.
Nice work @akashc777 🎉

[vinayaksh42]

Great work @akashc777

[welcome]

Thanks for your contribution to the Layer5 community! 🎉

[leecalcote]

Teamwork!