Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Site] Add links to GetNighthawk mailing lists #101

Closed
leecalcote opened this issue May 5, 2021 · 13 comments · Fixed by #107
Closed

[Site] Add links to GetNighthawk mailing lists #101

leecalcote opened this issue May 5, 2021 · 13 comments · Fixed by #107
Assignees
Labels
framework/jekyll good first issue Good for newcomers help wanted Extra attention is needed kind/enhancement Improvement in current feature

Comments

@leecalcote
Copy link
Member

Current Behavior
Project mailing lists exist, but are not shown on the site.

Desired Behavior

These lists should be available for anyone to join:

  • Users
  • [Developers(https://groups.google.com/a/getnighthawk.dev/g/developers)
  • Maintainers

Contributor Resources

@leecalcote leecalcote added good first issue Good for newcomers help wanted Extra attention is needed kind/enhancement Improvement in current feature framework/jekyll labels May 5, 2021
@leecalcote
Copy link
Member Author

@austinogiza will you supply a mockup for where these lists should be placed?

@austinogiza
Copy link

@akashc777
Copy link
Contributor

akashc777 commented May 13, 2021

Hi 👋 @leecalcote,
can I work on this?

@leecalcote
Copy link
Member Author

That would be great. Yes, @akashc777

@akashc777
Copy link
Contributor

akashc777 commented May 13, 2021

please can I get access to the Figma file @leecalcote @austinogiza

my email: [email protected]

@austinogiza
Copy link

@akashc777 Just sent it

@akashc777
Copy link
Contributor

akashc777 commented May 13, 2021

Screenshot 2021-05-14 at 12 27 10 AM

This one right ? But the footer is different compared to live site... the logo is also different 🙄

@leecalcote
Copy link
Member Author

https://layer5.io/brands - has the latest, bird-looking logo, which is the correct one. I think @austinogiza has a more condensed version of this footer mockup, but I'm not sure... @austinogiza?

@akashc777
Copy link
Contributor

@leecalcote I can add CSS/SCSS files while adding the mailing list section right?

@leecalcote
Copy link
Member Author

Right, yes. ✔️

@austinogiza
Copy link

austinogiza commented May 13, 2021

@akashc777 I apologize for that, I have updated the figma file to reflect the logo on the current website, sorry for the confusion

@akashc777
Copy link
Contributor

@austinogiza I got confused since the alignment on the live site is different than in the Figma prototype (looks better in Figma i think some CSS issue on live site ).

Btw where can I find the designs for mobile view?

sorry for too many questions 😅

@austinogiza
Copy link

@akashc777 I will provide the mobile view shortly, do hit me up on slack so I notify you when they are done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
framework/jekyll good first issue Good for newcomers help wanted Extra attention is needed kind/enhancement Improvement in current feature
Development

Successfully merging a pull request may close this issue.

3 participants