Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All: Update yarn install #6790

Merged
merged 5 commits into from
Aug 31, 2022
Merged

All: Update yarn install #6790

merged 5 commits into from
Aug 31, 2022

Conversation

asrient
Copy link
Contributor

@asrient asrient commented Aug 29, 2022

Fixes

An issue where a fresh yarn install after clone fails due to post-install steps not following proper order. This is related to this PR comment.
As also discussed in discord.

➤ YN0000: [@joplin/app-desktop]: Copying packages/pdf-viewer/dist => packages/app-desktop/vendor/lib/@joplin/pdf-viewer
➤ YN0000: [@joplin/app-desktop]: withRetry: Failed calling function - will retry (0) [Error: ENOENT: no such file or directory, lstat '/home/dae/JoplinDev/cliedit/joplin/packages/pdf-viewer/dist'] {
➤ YN0000: [@joplin/app-desktop]:   errno: -2,
➤ YN0000: [@joplin/app-desktop]:   code: 'ENOENT',
➤ YN0000: [@joplin/app-desktop]:   syscall: 'lstat',
➤ YN0000: [@joplin/app-desktop]:   path: '/home/dae/JoplinDev/cliedit/joplin/packages/pdf-viewer/dist'
➤ YN0000: [@joplin/app-desktop]: }

To fix this I have added a new argument --topological to the buildParallel command that was previously only added to buildSequential.

-t,--topological

Run the command after all workspaces it depends on (regular) have finished.

Documentation for the argument is here.

References

https://yarnpkg.com/cli/workspaces/foreach
yarnpkg/berry#2046
#6748

@laurent22 laurent22 merged commit 8d67aef into laurent22:dev Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants