Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDF Viewer: Zoom In/Out #6748

Merged
merged 17 commits into from
Aug 28, 2022
Merged

PDF Viewer: Zoom In/Out #6748

merged 17 commits into from
Aug 28, 2022

Conversation

asrient
Copy link
Contributor

@asrient asrient commented Aug 14, 2022

This is a subset of the previously opened PR: #6740

Major features added to the viewer

  • Zoom in/ zoom out.

Screenshot

Screen Shot 2022-08-27 at 9 17 46 PM

Screen.Recording.2022-08-27.at.9.17.51.PM.mov

@laurent22
Copy link
Owner

This is wrong, I see the same code as in #6747

@laurent22
Copy link
Owner

@asrient, please fix the conflicts and rebase your branch so that it can be reviewed.

@laurent22
Copy link
Owner

ok looks good, let's merge

@laurent22 laurent22 merged commit 6498f94 into laurent22:dev Aug 28, 2022
@asrient
Copy link
Contributor Author

asrient commented Aug 28, 2022

Hi, I was about to mention it here, if you notice there was a change in build command in root package.json.
After adding some new packages to pdf-viewer related to fontawesome, I noticed the build on CI was failing. On inspection I saw that everytime, app-desktop is being built before pdf-viewer and this caused copying build assets of the viewer to fail.
To fix this I added --topological arg to buildSequential command.

-t,--topological

Run the command after all workspaces it depends on (regular) have finished.

Documentation for the argument is here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants