prepare 8.3.0 release #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parameterize CI against multiple Xcode versions. Pin to exact dependency versions and remove resolved package files.
Add spaces in comments for new comment spacing lint rule.
As decided in the [spec], we are removing the special behavior of the secondary attribute. Going forward, secondary will be treated like any other attribute, and will no longer be included when determining the bucket for a context. [spec]: https://launchdarkly.atlassian.net/wiki/spaces/ENG/pages/2165212563/Consistent+and+Transparent+Rollout+Behavior+Unifying+Percent+Rollout+and+Traffic+Allocation
To help ease the upgrade path, we are going to allow consumers of the SDK to continue providing LDUser objects to key methods in the LDClient instead of the newer LDContext type.
This commit addresses a few last standing items I noticed with the iOS SDK: 1. We had temporarily disabled the contract tests in CI until the published version supported client side tests. This has now been re-enabled. 2. I restored the LDUser and ObjcLDUser objects a few commits ago, but failed to add them back to the generated docs configuration. 3. I noticed the inline configuration option hadn't been removed (not sure how I missed that).
The event payload based on our specifications should only have `redactedAttributes`, not `privateAttributes` in the payload. No private attribute values were sent even before this fix, only the field names were duplicated. Please see the Slack threads linked in the shortcut ticket for more details.
**Requirements** - [ ] I have added test coverage for new or changed functionality (Skipping this, that seems like a silly test to add) - [x] I have followed the repository's [pull request submission guidelines](../blob/v6/CONTRIBUTING.md#submitting-pull-requests) - [x] I have validated my changes against all supported platform versions **Related issues** https://app.shortcut.com/launchdarkly/story/198156/fix-ios-builder-tryset-for-kind
TLS 1.1 has been deprecated for a long time and has been dropped by most major providers. The LaunchDarkly APIs haven't accepted anything lower than TLS 1.2 for a long time. We are therefore forcing TLS 1.2 as the minimum going forward in this library.
This doesn't actually change any behavior because we override the default retry behavior, and that is all that changed since 3.1.0. However, we do not want the SDK to drift too far from the eventsource implementation, so I try to update it each time.
This pull request was auto generated by the Launchdarkly Github Standards automation platform. * Add default CODEOWNERS file
LDUser functionality has been replaced with the more flexible LDContext concept which all LaunchDarkly SDKs will support. We retained LDUser through the first major release to aide with the adoption transition, but as we near the next release, we need to alert customers that support will be ending.
Merging public into private. --------- Co-authored-by: ld-repository-standards[bot] <113625520+ld-repository-standards[bot]@users.noreply.github.com> Co-authored-by: Kane Parkinson <[email protected]>
tanderson-ld
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[8.3.0] - 2023-09-08
Changed:
LDValue.init(integerLiteral: Double)as this method signature is misleading. A newLDValue.init(integerLiteral: Int)signature has been added for clarity.