Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SwiftPM - Tools Version 5.2 #233

Closed
escakot opened this issue Jan 7, 2021 · 2 comments
Closed

SwiftPM - Tools Version 5.2 #233

escakot opened this issue Jan 7, 2021 · 2 comments

Comments

@escakot
Copy link
Contributor

escakot commented Jan 7, 2021

Is your feature request related to a problem? Please describe.
Importing the LD SDK through SwiftPM will import dev/test dependencies which is not ideal.
image

Describe the solution you'd like
Updating to Swift Tools 5.2 and minor changes to Package.swift will resolve this. I've tested it on my own fork. Let me know if you would like to me to make a PR.
image

Describe alternatives you've considered
N/A

Additional context
We're currently using Carthage to install the LD sdk. We're planning to switch over to SwiftPM soon.

@gwhelanLD
Copy link
Contributor

Hi @escakot,

Great suggestion, we'd love to see a PR for this. We'd just need to verify that it should work across the various supported installation methods. Hopefully this sort of change should only reduce the complexity of including the SDK within applications.

Thanks,
@gwhelanLD

@gwhelanLD
Copy link
Contributor

Thanks again for your PR! I'm closing this issue now that it's been included in the 5.4.2 release.

Thanks,
@gwhelanLD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants