Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(common): allow overriding fees in writeContract and sendTransaction #3288

Merged
merged 2 commits into from
Oct 14, 2024

Conversation

alvrs
Copy link
Member

@alvrs alvrs commented Oct 14, 2024

No description provided.

Copy link

changeset-bot bot commented Oct 14, 2024

🦋 Changeset detected

Latest commit: e8cf238

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 24 packages
Name Type
@latticexyz/common Patch
@latticexyz/block-logs-stream Patch
@latticexyz/cli Patch
@latticexyz/config Patch
@latticexyz/dev-tools Patch
@latticexyz/explorer Patch
@latticexyz/faucet Patch
@latticexyz/protocol-parser Patch
@latticexyz/store-indexer Patch
@latticexyz/store-sync Patch
@latticexyz/store Patch
@latticexyz/world-modules Patch
@latticexyz/world Patch
@latticexyz/stash Patch
@latticexyz/react Patch
@latticexyz/world-module-metadata Patch
@latticexyz/abi-ts Patch
create-mud Patch
@latticexyz/gas-report Patch
@latticexyz/recs Patch
@latticexyz/schema-type Patch
solhint-config-mud Patch
solhint-plugin-mud Patch
@latticexyz/utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

holic
holic previously approved these changes Oct 14, 2024
@alvrs
Copy link
Member Author

alvrs commented Oct 14, 2024

Was wondering why we even did it in this order in the first place and i think it's an artifact from 6c8ab47 - where we prepared the request async from sending it and then sent it with the latest fee values. In other words, safe to change the order to allow users override the values i think.

@alvrs alvrs marked this pull request as ready for review October 14, 2024 21:35
@alvrs alvrs merged commit fe98442 into main Oct 14, 2024
12 of 13 checks passed
@alvrs alvrs deleted the alvrs/override-gas branch October 14, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants