Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom estimate fees action for cached fees #3289

Open
holic opened this issue Oct 14, 2024 · 1 comment
Open

custom estimate fees action for cached fees #3289

holic opened this issue Oct 14, 2024 · 1 comment

Comments

@holic
Copy link
Member

holic commented Oct 14, 2024

currently we fetch+override fees in writeContract and sendTransaction (which recently lead to a bug and fixed in #3288)

instead, we could add an action override for estimateFeesPerGas that would cache/refresh these values and allow us to remove the manual overrides of args in writeContract/sendTransaction

@holic holic changed the title replace cached fees approach with estimate fees action use estimate fees action for cached fees Oct 14, 2024
@holic holic changed the title use estimate fees action for cached fees custom estimate fees action for cached fees Oct 14, 2024
@holic
Copy link
Member Author

holic commented Oct 14, 2024

note that whatever uses this new may need to override the rest of the actions in the call stack (e.g. prepareTransactionRequest) due to the issue demonstrated in wevm/viem#2680 (comment)

@holic holic closed this as completed Oct 14, 2024
@github-project-automation github-project-automation bot moved this to Done in MUD Oct 14, 2024
@holic holic reopened this Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants
@holic and others