-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): quieter automine #3212
Conversation
🦋 Changeset detectedLatest commit: 2cfb2d5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 26 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
74501fa
to
b009443
Compare
export type EnableAutomineResult = { reset: () => Promise<void> }; | ||
export type EnableAutomineResult = undefined | (() => Promise<void>); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a super strong opinion, but the thing i like about returning an object with named parameter is that it's self-documenting, whereas with a function i need to look at the source / docs to know what the function does.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense! I reverted back to reset
function and changed how we call it
currently if you deploy to a non-anvil chain, the deploy starts out with a big error
we can probably just quiet these