Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): quieter automine #3212

Merged
merged 4 commits into from
Sep 20, 2024
Merged

feat(cli): quieter automine #3212

merged 4 commits into from
Sep 20, 2024

Conversation

holic
Copy link
Member

@holic holic commented Sep 20, 2024

currently if you deploy to a non-anvil chain, the deploy starts out with a big error

  mud:cli Enabling automine +0ms
  mud:cli Skipping automine +43ms
  mud:cli MethodNotFoundRpcError: The method "anvil_getAutomine" does not exist / is not available.
  mud:cli
  mud:cli URL: [http://](https://rpc.garnetchain.com/)
  mud:cli Request body: {"method":"anvil_getAutomine"}
  mud:cli
  mud:cli Details: Method not found
  mud:cli Version: 2.21.6
  mud:cli     at withRetry.delay.count.count (/Users/kevin/Projects/latticexyz/eat-the-fly/node_modules/.pnpm/[email protected][email protected][email protected][email protected][email protected]/node_modules/viem/utils/buildRequest.ts:132:25)
  mud:cli     at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

we can probably just quiet these

Copy link

changeset-bot bot commented Sep 20, 2024

🦋 Changeset detected

Latest commit: 2cfb2d5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 26 packages
Name Type
@latticexyz/cli Patch
@latticexyz/world-modules Patch
mock-game-contracts Patch
@latticexyz/abi-ts Patch
@latticexyz/block-logs-stream Patch
@latticexyz/common Patch
@latticexyz/config Patch
create-mud Patch
@latticexyz/dev-tools Patch
@latticexyz/explorer Patch
@latticexyz/faucet Patch
@latticexyz/gas-report Patch
@latticexyz/protocol-parser Patch
@latticexyz/react Patch
@latticexyz/recs Patch
@latticexyz/schema-type Patch
solhint-config-mud Patch
solhint-plugin-mud Patch
@latticexyz/stash Patch
@latticexyz/store-indexer Patch
@latticexyz/store-sync Patch
@latticexyz/store Patch
@latticexyz/utils Patch
@latticexyz/world-module-metadata Patch
@latticexyz/world Patch
ts-benchmarks Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@holic holic force-pushed the holic/quieter-automine branch from 74501fa to b009443 Compare September 20, 2024 12:57
export type EnableAutomineResult = { reset: () => Promise<void> };
export type EnableAutomineResult = undefined | (() => Promise<void>);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a super strong opinion, but the thing i like about returning an object with named parameter is that it's self-documenting, whereas with a function i need to look at the source / docs to know what the function does.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense! I reverted back to reset function and changed how we call it

alvrs
alvrs previously approved these changes Sep 20, 2024
alvrs
alvrs previously approved these changes Sep 20, 2024
@holic holic marked this pull request as ready for review September 20, 2024 13:14
@holic holic merged commit 58f101e into main Sep 20, 2024
7 of 8 checks passed
@holic holic deleted the holic/quieter-automine branch September 20, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants