make return type optional

latticexyz · Sep 20, 2024 · b009443 · b009443
1 parent becbe49
commit b009443
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/packages/cli/src/runDeploy.ts b/packages/cli/src/runDeploy.ts
@@ -165,7 +165,7 @@ export async function runDeploy(opts: DeployOptions): Promise<WorldDeploy> {
   }
 
   // Reset mining mode after deploy
-  await resetMiningMode();
+  await resetMiningMode?.();
 
   console.log(chalk.green("Deployment completed in", (Date.now() - startTime) / 1000, "seconds"));
 

diff --git a/packages/cli/src/utils/enableAutomine.ts b/packages/cli/src/utils/enableAutomine.ts
@@ -12,14 +12,12 @@ type MiningMode =
       blockTime: number;
     };
 
-export type EnableAutomineResult = () => Promise<void>;
+export type EnableAutomineResult = undefined | (() => Promise<void>);
 
 export async function enableAutomine(client: Client): Promise<EnableAutomineResult> {
   const miningMode = await getMiningMode(client).catch(() => undefined);
   // doesn't support automine or is already in automine
-  if (!miningMode || miningMode.type === "automine") {
-    return async () => {};
-  }
+  if (!miningMode || miningMode.type === "automine") return;
 
   debug("Enabling automine");
   await setMiningMode(client, { type: "automine" });