Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(world): make AccessControl lib usable outside of world package #3034

Merged
merged 5 commits into from
Aug 15, 2024

Conversation

holic
Copy link
Member

@holic holic commented Aug 15, 2024

fixes #1853

Copy link

changeset-bot bot commented Aug 15, 2024

🦋 Changeset detected

Latest commit: 57ea59a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 25 packages
Name Type
@latticexyz/world-module-metadata Patch
@latticexyz/world-modules Patch
@latticexyz/world Patch
@latticexyz/cli Patch
mock-game-contracts Patch
@latticexyz/dev-tools Patch
@latticexyz/store-sync Patch
ts-benchmarks Patch
@latticexyz/store-indexer Patch
@latticexyz/abi-ts Patch
@latticexyz/block-logs-stream Patch
@latticexyz/common Patch
@latticexyz/config Patch
create-mud Patch
@latticexyz/faucet Patch
@latticexyz/gas-report Patch
@latticexyz/protocol-parser Patch
@latticexyz/query Patch
@latticexyz/react Patch
@latticexyz/recs Patch
@latticexyz/schema-type Patch
solhint-config-mud Patch
solhint-plugin-mud Patch
@latticexyz/store Patch
@latticexyz/utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@holic holic marked this pull request as ready for review August 15, 2024 10:06
@holic holic requested a review from alvrs as a code owner August 15, 2024 10:06
@holic holic requested review from ludns and qbzzt as code owners August 15, 2024 10:14
"gasUsed": 6521
"gasUsed": 9111
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this increased because the tests still use the non-_-prefixed method, should we add variants of each of these for the _ methods to compare and still have a gas report for the internally used methods?

Copy link
Member Author

@holic holic Aug 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't think it was necessary to have gas reports for all the internal _ method variants (since they're internal) and the gas use is captured by the tests for functions using these internal methods (which didn't change in this PR since there was no gas change)

@holic holic merged commit 6a66f57 into main Aug 15, 2024
13 checks passed
@holic holic deleted the holic/world-access-control branch August 15, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Combine AccessControlLib in world-module and AccessControl in world
2 participants