-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(world): make AccessControl lib usable outside of world package #3034
Conversation
🦋 Changeset detectedLatest commit: 57ea59a The changes in this PR will be included in the next version bump. This PR includes changesets to release 25 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
"gasUsed": 6521 | ||
"gasUsed": 9111 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume this increased because the tests still use the non-_
-prefixed method, should we add variants of each of these for the _
methods to compare and still have a gas report for the internally used methods?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't think it was necessary to have gas reports for all the internal _
method variants (since they're internal) and the gas use is captured by the tests for functions using these internal methods (which didn't change in this PR since there was no gas change)
fixes #1853