Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combine AccessControlLib in world-module and AccessControl in world #1853

Closed
alvrs opened this issue Nov 1, 2023 · 0 comments · Fixed by #3034
Closed

Combine AccessControlLib in world-module and AccessControl in world #1853

alvrs opened this issue Nov 1, 2023 · 0 comments · Fixed by #3034
Labels
blocked by audit This is blocked by code that is currently being audited

Comments

@alvrs
Copy link
Member

alvrs commented Nov 1, 2023 •
edited by holic
Loading

Though I understand why it's in world-modules, would it maybe be better to have a single AccessControl lib with hasAccess/_hasAccess etc, to have all the logic in 1 place and let it mirror the table methods?

Originally posted by @dk1a in #1793 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked by audit This is blocked by code that is currently being audited
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(world): make AccessControl lib usable outside of world package latticexyz/mud
1 participant
@alvrs