You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
since we already import/depend on world from world-modules, maybe we remove the world-modules one?
The text was updated successfully, but these errors were encountered:
holic
changed the title
dedupe world's AccessControl and world-module's AccessControlLib
dedupe world's AccessControl and world-modules' AccessControlLibJan 10, 2024
They are actually slightly different, according to this comment in AccessControlLib.
* This library is functionally equivalent with the AccessControl library from world,
* but uses StoreSwitch instead of always reading from own storage.
We could use the world-modules version as the default, but it would make world more expensive I guess.
I bet we could consolidate though, with one AccessControl lib and methods like hasAccess (using StoreSwitch) and _hasAccess (using _-prefixed methods) variants where we need the gas benefits
they're the same file
since we already import/depend on world from world-modules, maybe we remove the world-modules one?
The text was updated successfully, but these errors were encountered: