Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dedupe world's AccessControl and world-modules' AccessControlLib #2104

Closed
holic opened this issue Jan 10, 2024 · 3 comments
Closed

dedupe world's AccessControl and world-modules' AccessControlLib #2104

holic opened this issue Jan 10, 2024 · 3 comments

Comments

@holic
Copy link
Member

holic commented Jan 10, 2024

they're the same file

since we already import/depend on world from world-modules, maybe we remove the world-modules one?

@holic holic changed the title dedupe world's AccessControl and world-module's AccessControlLib dedupe world's AccessControl and world-modules' AccessControlLib Jan 10, 2024
@yonadaa
Copy link
Contributor

yonadaa commented Jan 12, 2024

They are actually slightly different, according to this comment in AccessControlLib.

 * This library is functionally equivalent with the AccessControl library from world,
 * but uses StoreSwitch instead of always reading from own storage.

We could use the world-modules version as the default, but it would make world more expensive I guess.

@holic
Copy link
Member Author

holic commented Jan 12, 2024

I bet we could consolidate though, with one AccessControl lib and methods like hasAccess (using StoreSwitch) and _hasAccess (using _-prefixed methods) variants where we need the gas benefits

@holic
Copy link
Member Author

holic commented Aug 15, 2024

closing as a dupe of #1853

@holic holic closed this as completed Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants