Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(create-mud): use app namespace #2823

Merged
merged 15 commits into from
May 14, 2024
Merged

Conversation

qbzzt
Copy link
Contributor

@qbzzt qbzzt commented May 14, 2024

Replacing #2816 , #2817 , #2818 , #2819 , #2821

@qbzzt qbzzt requested review from alvrs, holic and yonadaa as code owners May 14, 2024 15:14
Copy link

changeset-bot bot commented May 14, 2024

🦋 Changeset detected

Latest commit: e82297f

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@qbzzt qbzzt changed the title feat(templates): move main code into namespace feat(templates): move app code into namespace May 14, 2024
@holic holic changed the title feat(templates): move app code into namespace feat(create-mud): use app namespace May 14, 2024
@holic holic merged commit 1836024 into main May 14, 2024
12 checks passed
@holic holic deleted the 240514-templates-use-namespace branch May 14, 2024 16:48
@goller
Copy link

goller commented May 14, 2024

Hi @holic, I work at depot.dev and we are seeing the test job for this PR seemingly stuck running for over three hours. Is that expected?

https://github.com/latticexyz/mud/actions/runs/9083126574/job/24961130133

@holic
Copy link
Member

holic commented May 14, 2024

Hi @holic, I work at depot.dev and we are seeing the test job for this PR seemingly stuck running for over three hours. Is that expected?

https://github.com/latticexyz/mud/actions/runs/9083126574/job/24961130133

Whoops, nope! Thanks for the heads up! I'll add some timeouts to these.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants