Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(template/vanilla): use a namespace 🏎 #2816

Closed
wants to merge 3 commits into from

Conversation

qbzzt
Copy link
Contributor

@qbzzt qbzzt commented May 13, 2024

No description provided.

Copy link

changeset-bot bot commented May 13, 2024

⚠️ No Changeset found

Latest commit: b129d8e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@qbzzt qbzzt marked this pull request as ready for review May 14, 2024 00:36
@qbzzt qbzzt requested review from alvrs, holic and yonadaa as code owners May 14, 2024 00:36
@qbzzt
Copy link
Contributor Author

qbzzt commented May 14, 2024

I don't know how to fix the test, but I released a snapshot and it works.

@qbzzt qbzzt changed the title feat(template/vanilla): use a namespace feat(template/vanilla): use a namespace 🏎 May 14, 2024
@holic
Copy link
Member

holic commented May 14, 2024

I don't know how to fix the test, but I released a snapshot and it works.

need to run codegen! pnpm run build from packages/contracts

@qbzzt
Copy link
Contributor Author

qbzzt commented May 14, 2024

I don't know how to fix the test, but I released a snapshot and it works.

need to run codegen! pnpm run build from packages/contracts

Thank you! I worked here, and I'm now doing the same on the other PRs.

@holic
Copy link
Member

holic commented May 14, 2024

any chance we can do all the templates in one PR?

@@ -1,6 +1,7 @@
import { defineWorld } from "@latticexyz/world";

export default defineWorld({
namespace: "counter",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thoughts about using home as default namespace in templates? cc @holic

@qbzzt
Copy link
Contributor Author

qbzzt commented May 14, 2024 via email

@qbzzt
Copy link
Contributor Author

qbzzt commented May 14, 2024

Closed in favor of a single PR with all the templates.

@qbzzt qbzzt closed this May 14, 2024
@holic holic deleted the 240513-vanilla-template-use-namespace branch May 14, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants