-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(template/vanilla): use a namespace 🏎 #2816
Conversation
|
I don't know how to fix the test, but I released a snapshot and it works. |
need to run codegen! |
Thank you! I worked here, and I'm now doing the same on the other PRs. |
any chance we can do all the templates in one PR? |
@@ -1,6 +1,7 @@ | |||
import { defineWorld } from "@latticexyz/world"; | |||
|
|||
export default defineWorld({ | |||
namespace: "counter", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thoughts about using home
as default namespace in templates? cc @holic
How about `main`?
…On Tue, May 14, 2024, 8:56 AM alvarius ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In templates/vanilla/packages/contracts/mud.config.ts
<#2816 (comment)>:
> @@ -1,6 +1,7 @@
import { defineWorld } from ***@***.***/world";
export default defineWorld({
+ namespace: "counter",
thoughts about using home as default namespace in templates? cc @holic
<https://github.com/holic>
—
Reply to this email directly, view it on GitHub
<#2816 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADBCGGIDWK73EOVQEKFFVL3ZCIJYFAVCNFSM6AAAAABHVB7GFKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDANJVGQ2TSNZWGM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Closed in favor of a single PR with all the templates. |
No description provided.