Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): remove postdeploy gas setting in favor of script options #2756

Merged
merged 2 commits into from
Apr 28, 2024

Conversation

holic
Copy link
Member

@holic holic commented Apr 28, 2024

reverts #2638

  • got a report that postdeploy via mud deploy was waiting ~forever for txs, prob due to gas too low
  • ran postdeploy script manually with garnet RPC and saw that it set the gas fee appropriately
  • if you want to set manually during mud deploy, you can now use mud deploy --forgeScriptOptions (feat(cli): add user-specified PostDeploy forge options #2703)

Copy link

changeset-bot bot commented Apr 28, 2024

🦋 Changeset detected

Latest commit: c5205ac

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 24 packages
Name Type
@latticexyz/cli Patch
mock-game-contracts Patch
@latticexyz/abi-ts Patch
@latticexyz/block-logs-stream Patch
@latticexyz/common Patch
@latticexyz/config Patch
create-mud Patch
@latticexyz/dev-tools Patch
@latticexyz/faucet Patch
@latticexyz/gas-report Patch
@latticexyz/protocol-parser Patch
@latticexyz/query Patch
@latticexyz/react Patch
@latticexyz/recs Patch
@latticexyz/schema-type Patch
@latticexyz/services Patch
solhint-config-mud Patch
solhint-plugin-mud Patch
@latticexyz/store-indexer Patch
@latticexyz/store-sync Patch
@latticexyz/store Patch
@latticexyz/utils Patch
@latticexyz/world-modules Patch
@latticexyz/world Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@holic holic marked this pull request as ready for review April 28, 2024 21:46
@holic holic requested review from alvrs and yonadaa as code owners April 28, 2024 21:46
@holic holic changed the title fix(cli): remove postdeploy gas setting fix(cli): remove postdeploy gas setting in favor of script options Apr 28, 2024
@holic holic merged commit 074ed66 into main Apr 28, 2024
13 checks passed
@holic holic deleted the holic/revert-postdeploy-gas-price branch April 28, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants