feat(cli): add user-specified PostDeploy forge options #2703
Conversation
🦋 Changeset detectedLatest commit: 097ffed The changes in this PR will be included in the next version bump. This PR includes changesets to release 24 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| @@ -16,6 +16,7 @@ const devOptions = { | |||
| rpc: deployOptions.rpc, | |||
| configPath: deployOptions.configPath, | |||
| alwaysRunPostDeploy: deployOptions.alwaysRunPostDeploy, | |||
| postDeployForgeOptions: deployOptions.postDeployForgeOptions, | |||
There was a problem hiding this comment.
what about just forgeOptions to keep it the same as the other commands?
There was a problem hiding this comment.
if not, kinda wondering about forgeScriptOptions since I am kinda anticipating more than just post deploy in the future: #1755
There was a problem hiding this comment.
Some commands like deploy or test would have both forgeOptions and postDeployForgeOptions
I feel like it'd be confusing if dev-contracts is the only one where forgeOptions means something kind of different, but I can see the reasoning
Up to you, it's easy to change
There was a problem hiding this comment.
if not, kinda wondering about
forgeScriptOptionssince I am kinda anticipating more than just post deploy in the future: #1755
Sure, seems like a better name, updated
dk1a
force-pushed
the
dk1a/postdeployopts
branch
from
98e8a52 to
294ada5
Compare
fixes #2631
Similar to
test'sforgeOptions, this allows passing arbitrary user options toforge scriptIn my case this is needed for
--slow, without which the script breaks because it's too big