Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(store,world): fix StoreRead.getDynamicFieldLength #2680

Merged
merged 10 commits into from
Apr 17, 2024

Conversation

yonadaa
Copy link
Contributor

@yonadaa yonadaa commented Apr 17, 2024

No description provided.

Copy link

changeset-bot bot commented Apr 17, 2024

🦋 Changeset detected

Latest commit: c914009

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 24 packages
Name Type
@latticexyz/store Patch
@latticexyz/cli Patch
@latticexyz/dev-tools Patch
@latticexyz/query Patch
@latticexyz/react Patch
@latticexyz/store-indexer Patch
@latticexyz/store-sync Patch
@latticexyz/world-modules Patch
@latticexyz/world Patch
mock-game-contracts Patch
@latticexyz/abi-ts Patch
@latticexyz/block-logs-stream Patch
@latticexyz/common Patch
@latticexyz/config Patch
create-mud Patch
@latticexyz/faucet Patch
@latticexyz/gas-report Patch
@latticexyz/protocol-parser Patch
@latticexyz/recs Patch
@latticexyz/schema-type Patch
@latticexyz/services Patch
solhint-config-mud Patch
solhint-plugin-mud Patch
@latticexyz/utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@alvrs
Copy link
Member

alvrs commented Apr 17, 2024

let's also add a test for this

@alvrs
Copy link
Member

alvrs commented Apr 17, 2024

and a changeset that explains the impact

@yonadaa yonadaa changed the title fix: storeread uses storecore.getDynamicFieldLength fix(world): storeread uses storecore.getDynamicFieldLength Apr 17, 2024
@yonadaa yonadaa marked this pull request as ready for review April 17, 2024 14:40
@yonadaa yonadaa requested review from alvrs and holic as code owners April 17, 2024 14:40
@holic holic changed the title fix(world): storeread uses storecore.getDynamicFieldLength fix(store,world): storeread uses storecore.getDynamicFieldLength Apr 17, 2024
@holic holic changed the title fix(store,world): storeread uses storecore.getDynamicFieldLength fix(store,world): fix StoreREad.getDynamicFieldLength Apr 17, 2024
@holic holic changed the title fix(store,world): fix StoreREad.getDynamicFieldLength fix(store,world): fix StoreRead.getDynamicFieldLength Apr 17, 2024
@yonadaa yonadaa merged commit 103db6c into main Apr 17, 2024
14 checks passed
@yonadaa yonadaa deleted the yondaaa/store-read-dynamic-length branch April 17, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants