Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protocol version tests should take into account table schemas #2536

Open
holic opened this issue Mar 23, 2024 · 1 comment
Open

protocol version tests should take into account table schemas #2536

holic opened this issue Mar 23, 2024 · 1 comment

Comments

@holic
Copy link
Member

holic commented Mar 23, 2024

right now the protocol version just looks at the store/world ABIs, but what's also important is the schema of internal tables (e.g. store.Tables) in case fields change, encodings change, etc.

@holic holic changed the title protocol version should take into account table schemas protocol version tests should take into account table schemas Mar 23, 2024
@holic
Copy link
Member Author

holic commented Apr 17, 2024

maybe we could capture this by looking at bytecode and including it (or a hash of) in snapshots alongside ABIs

this is helpful to make sure we're capturing changes like #2680 in our protocol version tracking

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant