-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(store): restore bytesN helpers #2403
Conversation
To support packed uint96 types in tables.
🦋 Changeset detectedLatest commit: b836ed6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 31 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great spot! I wish there was a way we could not get the compiler warning
These were removed in #2090 as part of audit fixes because they appeared unused, but we missed that they are used by codegen (likely because the function signature is generated by a template string):
mud/packages/store/ts/codegen/field.ts
Line 269 in 1a82c27
Shoutout to @transmissions11 for spotting this and kicking this off in #2402
While I was here, I renamed the helpers from
Bytes.sliceN
toBytes.getBytesN
to both match theBytes.setBytesN
methods and to better differentiate this fromSlice
andSliceLib
utils.