Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(store,world): delete unused functions and variables [N-04] #2090

Merged
merged 6 commits into from
Jan 12, 2024

Conversation

yonadaa
Copy link
Contributor

@yonadaa yonadaa commented Jan 8, 2024

No description provided.

@yonadaa yonadaa requested review from alvrs and holic as code owners January 8, 2024 12:22
Copy link

changeset-bot bot commented Jan 8, 2024

⚠️ No Changeset found

Latest commit: dea38ca

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

// can be executed on the World. Modules are used to install tables,
// systems, hooks, and new entry point to a World in order to extend
// its capabilities.
bytes2 constant RESOURCE_MODULE = "md";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alvrs is it true that we don't use this anywhere?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't think we do! modules are not exactly resources that are installed into the world either like other kinds of resources (namespaces, tables, systems)

@@ -6,41 +6,12 @@ pragma solidity >=0.8.21;
* @notice Utility functions for bytes.
*/
library Bytes {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this library feels a little incomplete with half the bytes variants removed but 🤷‍♂️

maybe in the future, we move this into the common package or similar so that it represents a pure lib and not dependent on anything store related

@holic holic merged commit 7667fb0 into main Jan 12, 2024
11 checks passed
@holic holic deleted the yonadaaa/unused-functions-variables branch January 12, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants