-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(store,world): delete unused functions and variables [N-04] #2090
Conversation
|
a44128d
to
b887ec6
Compare
// can be executed on the World. Modules are used to install tables, | ||
// systems, hooks, and new entry point to a World in order to extend | ||
// its capabilities. | ||
bytes2 constant RESOURCE_MODULE = "md"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alvrs is it true that we don't use this anywhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i don't think we do! modules are not exactly resources that are installed into the world either like other kinds of resources (namespaces, tables, systems)
@@ -6,41 +6,12 @@ pragma solidity >=0.8.21; | |||
* @notice Utility functions for bytes. | |||
*/ | |||
library Bytes { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this library feels a little incomplete with half the bytes variants removed but 🤷♂️
maybe in the future, we move this into the common
package or similar so that it represents a pure lib and not dependent on anything store related
No description provided.