Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "refactor(store,world-modules): clean up error names/locations" #2337

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

holic
Copy link
Member

@holic holic commented Feb 28, 2024

Reverts #2334

We lost errors in ABIs in certain cases, which means viem can't decode certain errors. Gonna reevaluate this approach.

Copy link

changeset-bot bot commented Feb 28, 2024

⚠️ No Changeset found

Latest commit: 1039c1f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@holic holic marked this pull request as ready for review February 28, 2024 14:23
@holic holic requested review from alvrs and yonadaa as code owners February 28, 2024 14:23
@holic holic merged commit 2e288aa into main Feb 28, 2024
10 of 11 checks passed
@holic holic deleted the revert-2334-holic/error-names-cleanup branch February 28, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants