refactor(store,world-modules): clean up error names/locations #2334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8544b52 The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
yonadaa
previously approved these changes
Feb 28, 2024
holic
commented
Feb 28, 2024
| @@ -17,3 +17,6 @@ error Store_InvalidValueSchemaLength(uint256 expected, uint256 received); | |||
| error Store_InvalidValueSchemaStaticLength(uint256 expected, uint256 received); | |||
| error Store_InvalidValueSchemaDynamicLength(uint256 expected, uint256 received); | |||
| error Store_InvalidSplice(uint40 startWithinField, uint40 deleteCount, uint40 fieldLength); | |||
|
|
|||
| /// @notice Error emitted when a function is not implemented. | |||
| error StoreHook_NotImplemented(); | |||
There was a problem hiding this comment.
kinda undecided on this being here
also considered making this a generic error NotImplemented() (so we can reuse the pattern in other contracts) but wasn't sure if that would be clear enough when the error is thrown somewhere in code
There was a problem hiding this comment.
I prefer the specific error name, but would not be against it being defined at the top of StoreHook
holic
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #2158