Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(noise): remove noise package #2304

Merged
merged 3 commits into from
Feb 26, 2024
Merged

chore(noise): remove noise package #2304

merged 3 commits into from
Feb 26, 2024

Conversation

yonadaa
Copy link
Contributor

@yonadaa yonadaa commented Feb 23, 2024

We don't use this package so better to stop maintaining it and remove it before stable release.

This was prompted by upgrading prettier in #2303, which caused a build error with @latticexyz/noise for some reason (see failed build).

@yonadaa yonadaa requested review from alvrs and holic as code owners February 23, 2024 17:22
Copy link

changeset-bot bot commented Feb 23, 2024

🦋 Changeset detected

Latest commit: 1c9af4b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages
Name Type
@latticexyz/noise Patch
@latticexyz/abi-ts Patch
@latticexyz/block-logs-stream Patch
@latticexyz/cli Patch
@latticexyz/common Patch
@latticexyz/config Patch
create-mud Patch
@latticexyz/dev-tools Patch
@latticexyz/ecs-browser Patch
@latticexyz/faucet Patch
@latticexyz/gas-report Patch
@latticexyz/network Patch
@latticexyz/phaserx Patch
@latticexyz/protocol-parser Patch
@latticexyz/react Patch
@latticexyz/recs Patch
@latticexyz/schema-type Patch
@latticexyz/services Patch
@latticexyz/solecs Patch
solhint-config-mud Patch
solhint-plugin-mud Patch
@latticexyz/std-client Patch
@latticexyz/std-contracts Patch
@latticexyz/store-cache Patch
@latticexyz/store-indexer Patch
@latticexyz/store-sync Patch
@latticexyz/store Patch
@latticexyz/utils Patch
@latticexyz/world-modules Patch
@latticexyz/world Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@alvrs
Copy link
Member

alvrs commented Feb 23, 2024

Agree with moving it out of the monorepo since it is very standalone and doesn't have any other dependencies in MUD, but looking at npm stats it is definitely being used so let's keep the code around. Created a new home for it here: https://github.com/latticexyz/noise

"@latticexyz/noise": patch
---

Removed the @latticexyz/noise package.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Removed the @latticexyz/noise package.
Moved the @latticexyz/noise out of the MUD monorepo and into a [new standalone repo](https://github.com/latticexyz/noise).

@yonadaa yonadaa merged commit 5a8dfc8 into main Feb 26, 2024
11 checks passed
@yonadaa yonadaa deleted the yonadaaa/remove-noise branch February 26, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants