Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade prettier to 3.2.5 and prettier-plugin-solidity to 1.3.1 #2303

Merged
merged 10 commits into from
Feb 29, 2024

Conversation

yonadaa
Copy link
Contributor

@yonadaa yonadaa commented Feb 23, 2024

Pulled out from #2302 (Solidity prettier needs to support events at file level)

@yonadaa yonadaa requested review from alvrs and holic as code owners February 23, 2024 16:53
Copy link

changeset-bot bot commented Feb 23, 2024

🦋 Changeset detected

Latest commit: 9d6b443

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages
Name Type
@latticexyz/common Patch
@latticexyz/block-logs-stream Patch
@latticexyz/cli Patch
@latticexyz/config Patch
@latticexyz/dev-tools Patch
@latticexyz/faucet Patch
@latticexyz/protocol-parser Patch
@latticexyz/store-indexer Patch
@latticexyz/store-sync Patch
@latticexyz/store Patch
@latticexyz/world-modules Patch
@latticexyz/world Patch
@latticexyz/react Patch
@latticexyz/abi-ts Patch
create-mud Patch
@latticexyz/ecs-browser Patch
@latticexyz/gas-report Patch
@latticexyz/network Patch
@latticexyz/noise Patch
@latticexyz/phaserx Patch
@latticexyz/recs Patch
@latticexyz/schema-type Patch
@latticexyz/services Patch
@latticexyz/solecs Patch
solhint-config-mud Patch
solhint-plugin-mud Patch
@latticexyz/std-client Patch
@latticexyz/std-contracts Patch
@latticexyz/store-cache Patch
@latticexyz/utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@yonadaa
Copy link
Contributor Author

yonadaa commented Feb 23, 2024

TIL we can remove @types/prettier: https://www.npmjs.com/package/@types/prettier

@yonadaa yonadaa changed the title chore: upgrade prettier-plugin-solidity to 1.3.1 chore: upgrade prettier to 3.2.5 and prettier-plugin-solidity to 1.3.1 Feb 23, 2024
holic
holic previously approved these changes Feb 27, 2024
Copy link
Member

@holic holic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! may need to be strategic about when we land this since this'll prob add merge conflicts to ~all PRs

@@ -269,6 +269,62 @@ function slice32(bytes memory data, uint256 start) internal pure returns (bytes3
| -------- | --------- | -------------------------------------------------------------------------- |
| `output` | `bytes32` | The extracted bytes32 value from the specified position in the bytes blob. |

## FieldLayout_Empty
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like I saw this in my PR too and IIRC had to clear out all the various foundry caches (cache, out, docs) before rebuilding/regenerating docs. Try that and see if this disappears?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, I've been playing with it to no results

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also be sure this has latest main too

@yonadaa yonadaa merged commit db314a7 into main Feb 29, 2024
11 checks passed
@yonadaa yonadaa deleted the yonadaaa/solidity-prettier-1.3.1 branch February 29, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants