-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade prettier to 3.2.5 and prettier-plugin-solidity to 1.3.1 #2303
Conversation
🦋 Changeset detectedLatest commit: 9d6b443 The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
a39a599
to
9305fd0
Compare
TIL we can remove |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! may need to be strategic about when we land this since this'll prob add merge conflicts to ~all PRs
docs/pages/store/reference/misc.mdx
Outdated
@@ -269,6 +269,62 @@ function slice32(bytes memory data, uint256 start) internal pure returns (bytes3 | |||
| -------- | --------- | -------------------------------------------------------------------------- | | |||
| `output` | `bytes32` | The extracted bytes32 value from the specified position in the bytes blob. | | |||
|
|||
## FieldLayout_Empty |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like I saw this in my PR too and IIRC had to clear out all the various foundry caches (cache, out, docs) before rebuilding/regenerating docs. Try that and see if this disappears?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea, I've been playing with it to no results
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also be sure this has latest main too
Pulled out from #2302 (Solidity prettier needs to support events at file level)