fix(store-sync): fix overflowing column types, bump postgres sync version #2270
Conversation
yonadaa
commented
Feb 16, 2024
•
yonadaa
commented
- extended fix for postgres indexer: uint16 doesn't fit into postgres smallint column type #2077
- bumps postgres sync version
🦋 Changeset detectedLatest commit: 0ce8e4d The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| case "int24": | ||
| case "int32": | ||
| // integer = 4 bytes (https://www.postgresql.org/docs/current/datatype-numeric.html#DATATYPE-INT) | ||
| return asNumber(name, "integer"); | ||
|
|
||
| case "uint32": | ||
| case "uint40": | ||
| case "uint48": | ||
| case "int40": |
There was a problem hiding this comment.
can't comment below but does int48 need to be bumped to the next size up too?
There was a problem hiding this comment.
can't comment below
What does that mean sorry? Anyway I don't think so, int48 is already a postgres bigint here?
There was a problem hiding this comment.
We chatted IRL and we mixed up the JavaScript and Postgres column types.
but maybe uint64 and int64 need to move down because they may not fit within the bigint column type
There was a problem hiding this comment.
@holic it definitely doesn't fit - uint64 is 8 bytes unsigned, postgres bigint is 8 bytes signed:
https://www.postgresql.org/docs/current/datatype-numeric.html
yonadaa
changed the title
uint32 size
holic
changed the title
uint32 sizeuint32 size
holic
changed the title
uint32 size
