fix(store-sync): fix overflowing column types, bump postgres sync ver…

…sion (#2270) Co-authored-by: Kevin Ingersoll <[email protected]>
latticexyz · Feb 20, 2024 · 6c615b6 · 6c615b6
1 parent d1753d0
commit 6c615b6
Show file tree

Hide file tree

Showing 6 changed files with 20 additions and 15 deletions.
diff --git a/.changeset/fifty-guests-rescue.md b/.changeset/fifty-guests-rescue.md
@@ -0,0 +1,5 @@
+---
+"@latticexyz/store-sync": patch
+---
+
+Bumped the Postgres column size for `int32`, `uint32`, `int64`, and `uint64` types to avoid overflows
diff --git a/packages/store-sync/src/postgres-decoded/buildColumn.ts b/packages/store-sync/src/postgres-decoded/buildColumn.ts
@@ -11,29 +11,28 @@ export function buildColumn(name: string, schemaAbiType: SchemaAbiType) {
 
     case "uint8":
     case "uint16":
+    case "uint24":
     case "int8":
     case "int16":
-    case "uint24":
-    case "uint32":
     case "int24":
-    case "int32":
       // integer = 4 bytes (https://www.postgresql.org/docs/current/datatype-numeric.html#DATATYPE-INT)
       return asNumber(name, "integer");
 
+    case "uint32":
     case "uint40":
     case "uint48":
+    case "int32":
     case "int40":
     case "int48":
       // bigint = 8 bytes (https://www.postgresql.org/docs/current/datatype-numeric.html#DATATYPE-INT)
       return asNumber(name, "bigint");
 
     case "uint56":
-    case "uint64":
     case "int56":
-    case "int64":
       // bigint = 8 bytes (https://www.postgresql.org/docs/current/datatype-numeric.html#DATATYPE-INT)
       return asBigInt(name, "bigint");
 
+    case "uint64":
     case "uint72":
     case "uint80":
     case "uint88":
@@ -58,6 +57,7 @@ export function buildColumn(name: string, schemaAbiType: SchemaAbiType) {
     case "uint240":
     case "uint248":
     case "uint256":
+    case "int64":
     case "int72":
     case "int80":
     case "int88":
@@ -126,29 +126,28 @@ export function buildColumn(name: string, schemaAbiType: SchemaAbiType) {
 
     case "uint8[]":
     case "uint16[]":
+    case "uint24[]":
     case "int8[]":
     case "int16[]":
-    case "uint24[]":
-    case "uint32[]":
     case "int24[]":
-    case "int32[]":
       // integer = 4 bytes (https://www.postgresql.org/docs/current/datatype-numeric.html#DATATYPE-INT)
       return asNumberArray(name, "integer[]");
 
+    case "uint32[]":
     case "uint40[]":
     case "uint48[]":
+    case "int32[]":
     case "int40[]":
     case "int48[]":
       // bigint = 8 bytes (https://www.postgresql.org/docs/current/datatype-numeric.html#DATATYPE-INT)
       return asNumberArray(name, "bigint[]");
 
     case "uint56[]":
-    case "uint64[]":
     case "int56[]":
-    case "int64[]":
       // bigint = 8 bytes (https://www.postgresql.org/docs/current/datatype-numeric.html#DATATYPE-INT)
       return asBigIntArray(name, "bigint[]");
 
+    case "uint64[]":
     case "uint72[]":
     case "uint80[]":
     case "uint88[]":
@@ -173,6 +172,7 @@ export function buildColumn(name: string, schemaAbiType: SchemaAbiType) {
     case "uint240[]":
     case "uint248[]":
     case "uint256[]":
+    case "int64[]":
     case "int72[]":
     case "int80[]":
     case "int88[]":

diff --git a/packages/store-sync/src/postgres-decoded/buildTable.test.ts b/packages/store-sync/src/postgres-decoded/buildTable.test.ts
@@ -53,13 +53,13 @@ describe("buildTable", () => {
           "dataType": "custom",
           "name": "x",
           "notNull": true,
-          "sqlName": "integer",
+          "sqlName": "bigint",
         },
         "y": {
           "dataType": "custom",
           "name": "y",
           "notNull": true,
-          "sqlName": "integer",
+          "sqlName": "bigint",
         },
       }
     `);

diff --git a/packages/store-sync/src/postgres-decoded/createStorageAdapter.test.ts b/packages/store-sync/src/postgres-decoded/createStorageAdapter.test.ts
@@ -52,7 +52,7 @@ describe("createStorageAdapter", async () => {
         {
           "blockNumber": 20n,
           "chainId": 31337,
-          "version": "0.0.4",
+          "version": "0.0.5",
         },
       ]
     `);

diff --git a/packages/store-sync/src/postgres/createStorageAdapter.test.ts b/packages/store-sync/src/postgres/createStorageAdapter.test.ts
@@ -50,7 +50,7 @@ describe("createStorageAdapter", async () => {
         {
           "blockNumber": 20n,
           "chainId": 31337,
-          "version": "0.0.4",
+          "version": "0.0.5",
         },
       ]
     `);

diff --git a/packages/store-sync/src/postgres/version.ts b/packages/store-sync/src/postgres/version.ts
@@ -1 +1 @@
-export const version = "0.0.4";
+export const version = "0.0.5";
Original file line number	Diff line number	Diff line change
		@@ -1 +1 @@
		export const version = "0.0.4";
		export const version = "0.0.5";