Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(world): deployment salt by msg.sender #2210

Merged
merged 11 commits into from
Jan 30, 2024

Conversation

yonadaa
Copy link
Contributor

@yonadaa yonadaa commented Jan 30, 2024

Fixes #1850

@yonadaa yonadaa requested review from alvrs and holic as code owners January 30, 2024 10:41
Copy link

changeset-bot bot commented Jan 30, 2024

🦋 Changeset detected

Latest commit: 218294b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages
Name Type
@latticexyz/world Major
@latticexyz/cli Major
@latticexyz/dev-tools Major
@latticexyz/store-sync Major
@latticexyz/world-modules Major
@latticexyz/store-indexer Major
@latticexyz/abi-ts Major
@latticexyz/block-logs-stream Major
@latticexyz/common Major
@latticexyz/config Major
create-mud Major
@latticexyz/ecs-browser Major
@latticexyz/faucet Major
@latticexyz/gas-report Major
@latticexyz/network Major
@latticexyz/noise Major
@latticexyz/phaserx Major
@latticexyz/protocol-parser Major
@latticexyz/react Major
@latticexyz/recs Major
@latticexyz/schema-type Major
@latticexyz/services Major
@latticexyz/solecs Major
solhint-config-mud Major
solhint-plugin-mud Major
@latticexyz/std-client Major
@latticexyz/std-contracts Major
@latticexyz/store-cache Major
@latticexyz/store Major
@latticexyz/utils Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

holic
holic previously approved these changes Jan 30, 2024
@holic
Copy link
Member

holic commented Jan 30, 2024

do we need to regenerate test data after this change?

@holic holic changed the title feat(world): deployment salt includes msg.sender feat(world): deployment salt by msg.sender Jan 30, 2024
Co-authored-by: Kevin Ingersoll <[email protected]>
@yonadaa
Copy link
Contributor Author

yonadaa commented Jan 30, 2024

do we need to regenerate test data after this change?

It might not be strictly necessary (if nothing relies on addresses) but I'll do it anyway

@yonadaa yonadaa requested a review from holic January 30, 2024 16:03
@yonadaa yonadaa merged commit 6470fe1 into main Jan 30, 2024
11 checks passed
@yonadaa yonadaa deleted the yonadaaa/world-factory-sender-salt branch January 30, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WorldFactory: add sender to salt
2 participants