Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WorldFactory: add sender to salt #1850

Closed
holic opened this issue Nov 1, 2023 · 0 comments · Fixed by #2210
Closed

WorldFactory: add sender to salt #1850

holic opened this issue Nov 1, 2023 · 0 comments · Fixed by #2210
Assignees

Comments

@holic
Copy link
Member

holic commented Nov 1, 2023

worldAddress = Create2.deploy(bytecode, worldCount++);

We should add msg.sender here as part of the salt, so the address is derived from the creator of the world. Even better might be a per address count or a custom salt in addition to the sender, so folks can attempt to deploy worlds across chains with the same address, regardless of how many they've deployed before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants