feat(world-modules): add ERC721 module #1844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 65a8802 The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
alvrs
force-pushed
the
alvrs/erc721-puppet
branch
2 times, most recently
from
6de0e3c to
b57cf25
Compare
alvrs
force-pushed
the
alvrs/erc721-puppet
branch
from
3938d78 to
cb23f0f
Compare
alvrs
force-pushed
the
alvrs/erc721-puppet
branch
from
cb23f0f to
10b6c18
Compare
alvrs
force-pushed
the
alvrs/erc721-puppet
branch
from
0881dfd to
321dba4
Compare
holic
reviewed
Oct 31, 2023
| // (https://github.com/Vectorized/solady/blob/main/test/ERC721.t.sol) | ||
| ///////////////////////////////////////////////// | ||
|
|
||
| function testMint(uint256 id, address owner) public { |
There was a problem hiding this comment.
gas reports please! would love to see the gas of this vs solady
holic
previously approved these changes
Oct 31, 2023
| @@ -52,7 +51,7 @@ contract ERC20System is System, IERC20Mintable, PuppetMaster { | |||
| * {IERC20-balanceOf} and {IERC20-transfer}. | |||
| */ | |||
| function decimals() public view virtual returns (uint8) { | |||
| return Metadata.getDecimals(_metadataTableId(_namespace())); | |||
| return ERC20Metadata.getDecimals(_metadataTableId(_namespace())); | |||
There was a problem hiding this comment.
I don't feel strongly but wondering if these changes get moved to the ERC20 PR
There was a problem hiding this comment.
I generally agree, but in this case i'd prefer to not do the refactor for time reasons. We could merge the erc721 PR into the erc20 PR instead of merging both into main individually
| // SPDX-License-Identifier: MIT | ||
| pragma solidity >=0.8.21; | ||
|
|
||
| /* Autogenerated file. Do not edit manually. */ |
There was a problem hiding this comment.
aw man, I thought we had moved these to a codegen dir
|
|
||
| contract WrongReturnDataERC721Recipient is ERC721TokenReceiver { | ||
| function onERC721Received(address, address, uint256, bytes calldata) public virtual override returns (bytes4) { | ||
| return 0xCAFEBEEF; |
alvrs
force-pushed
the
alvrs/erc20
branch
2 times, most recently
from
3431d30 to
70446e7
Compare
alvrs
force-pushed
the
alvrs/erc721-puppet
branch
from
321dba4 to
26c6511
Compare
alvrs
force-pushed
the
alvrs/erc721-puppet
branch
from
73a9250 to
65a8802
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.