Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explore how to organise vendor code #2484

Open
yonadaa opened this issue Mar 20, 2024 · 1 comment
Open

explore how to organise vendor code #2484

yonadaa opened this issue Mar 20, 2024 · 1 comment

Comments

@yonadaa
Copy link
Contributor

yonadaa commented Mar 20, 2024

In the ERC721 PR (#1844) we copy-pasted code from OpenZeppelin instead of installing + importing the official files from NPM. We should think about how to organise this code so it's clear where it come from

@holic
Copy link
Member

holic commented Mar 20, 2024

Adding a new set of contracts as an npm dependency in e.g. world package means that forge/solc in world-modules or downstream templates won't know how to resolve that new dependency. We could teach it how via remappings but that gets hairy with transitive dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

2 participants