You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the ERC721 PR (#1844) we copy-pasted code from OpenZeppelin instead of installing + importing the official files from NPM. We should think about how to organise this code so it's clear where it come from
The text was updated successfully, but these errors were encountered:
Adding a new set of contracts as an npm dependency in e.g. world package means that forge/solc in world-modules or downstream templates won't know how to resolve that new dependency. We could teach it how via remappings but that gets hairy with transitive dependencies.
In the ERC721 PR (#1844) we copy-pasted code from OpenZeppelin instead of installing + importing the official files from NPM. We should think about how to organise this code so it's clear where it come from
The text was updated successfully, but these errors were encountered: