feat(world-modules): add ERC20 module #1789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b5dddc8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
holic
reviewed
Oct 18, 2023
| return MODULE_NAME; | ||
| } | ||
|
|
||
| function install(bytes memory args) public { |
There was a problem hiding this comment.
do we need an "already installed" check here?
holic
reviewed
Oct 18, 2023
holic
reviewed
Oct 18, 2023
holic
reviewed
Oct 18, 2023
| } | ||
|
|
||
| // Emit Transfer event on puppet | ||
| puppet().log(IERC20Events.Transfer.selector, _toBytes32(from), _toBytes32(to), abi.encode(value)); |
There was a problem hiding this comment.
wtb solidity native encodeLog like encodeCall
There was a problem hiding this comment.
we should open an EIP for that, would be nice for sure
alvrs
commented
Oct 31, 2023
holic
reviewed
Nov 1, 2023
|
|
||
| function _requireDependencies() internal view { | ||
| // If the PuppetModule is not installed yet, install it | ||
| if (InstalledModules.get(PUPPET_MODULE_NAME, keccak256(new bytes(0))) == address(0)) { |
There was a problem hiding this comment.
side note/not blocking: since we're starting to use this more, might be nice to lift this into Module as a helper function e.g. isInstalled() or isInstalled(module) and requireNotInstalled()
holic
previously approved these changes
Nov 1, 2023
…#1799) Co-authored-by: Fraser Scott <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MUD-native ERC20 token