Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add isInstalled to Module #1852

Closed
alvrs opened this issue Nov 1, 2023 · 1 comment
Closed

Add isInstalled to Module #1852

alvrs opened this issue Nov 1, 2023 · 1 comment
Labels
blocked by audit This is blocked by code that is currently being audited good first issue Good for newcomers

Comments

@alvrs
Copy link
Member

alvrs commented Nov 1, 2023 •
edited by holic
Loading

side note/not blocking: since we're starting to use this more, might be nice to lift this into Module as a helper function e.g. isInstalled() or isInstalled(module) and requireNotInstalled()

Originally posted by @holic in #1789 (comment)
@alvrs alvrs mentioned this issue Nov 1, 2023
Merged
@alvrs alvrs added blocked by audit This is blocked by code that is currently being audited good first issue Good for newcomers labels Nov 1, 2023
@R-Morpheus R-Morpheus mentioned this issue Dec 11, 2023
Merged
@holic
Copy link
Member

holic commented Jan 2, 2024

done in #2056

@holic holic closed this as completed Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked by audit This is blocked by code that is currently being audited good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@holic @alvrs