-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(store): default off storeArgument #1741
Conversation
🦋 Changeset detectedLatest commit: b994eaf The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@@ -129,13 +129,13 @@ | |||
"file": "test/World.t.sol", | |||
"test": "testSetRecord", | |||
"name": "Write data to the table", | |||
"gasUsed": 36896 | |||
"gasUsed": 39039 | |||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we care that this test jumped ~2k gas due to changing this to use StoreSwitch's stored address?
If so, I could warm the store address or do two writes (one cold, one warm), but not sure if it's a thing we're concerned with benchmarking in this context
closes #1723