Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(store): default off storeArgument #1741

Merged
merged 10 commits into from
Oct 12, 2023
Merged

feat(store): default off storeArgument #1741

merged 10 commits into from
Oct 12, 2023

Conversation

holic
Copy link
Member

@holic holic commented Oct 11, 2023

closes #1723

@changeset-bot
Copy link

changeset-bot bot commented Oct 11, 2023

🦋 Changeset detected

Latest commit: b994eaf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages
Name Type
@latticexyz/cli Major
@latticexyz/store Major
@latticexyz/world-modules Major
@latticexyz/world Major
create-mud Major
@latticexyz/dev-tools Major
@latticexyz/react Major
@latticexyz/store-indexer Major
@latticexyz/store-sync Major
@latticexyz/abi-ts Major
@latticexyz/block-logs-stream Major
@latticexyz/common Major
@latticexyz/config Major
@latticexyz/ecs-browser Major
@latticexyz/faucet Major
@latticexyz/gas-report Major
@latticexyz/network Major
@latticexyz/noise Major
@latticexyz/phaserx Major
@latticexyz/protocol-parser Major
@latticexyz/recs Major
@latticexyz/schema-type Major
@latticexyz/services Major
@latticexyz/solecs Major
solhint-config-mud Major
solhint-plugin-mud Major
@latticexyz/std-client Major
@latticexyz/std-contracts Major
@latticexyz/store-cache Major
@latticexyz/utils Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@@ -129,13 +129,13 @@
"file": "test/World.t.sol",
"test": "testSetRecord",
"name": "Write data to the table",
"gasUsed": 36896
"gasUsed": 39039
},
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we care that this test jumped ~2k gas due to changing this to use StoreSwitch's stored address?

If so, I could warm the store address or do two writes (one cold, one warm), but not sure if it's a thing we're concerned with benchmarking in this context

alvrs
alvrs previously approved these changes Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

don't include store argument in tablegen by default
2 participants