Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't include store argument in tablegen by default #1723

Closed
holic opened this issue Oct 10, 2023 · 0 comments · Fixed by #1741
Closed

don't include store argument in tablegen by default #1723

holic opened this issue Oct 10, 2023 · 0 comments · Fixed by #1741
Labels
good first issue Good for newcomers

Comments

@holic
Copy link
Member

holic commented Oct 10, 2023

We should turn this off by default because it's got significant trade-offs and you'll want to be careful when/how you use it. (case study: Sky Strife just lowered gas by ~half for one of their primary actions by removing the store param/arg)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(store): default off storeArgument latticexyz/mud
1 participant
@holic