Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(store): inline logic in codegenned set method which uses struct #1542

Merged
merged 6 commits into from
Sep 21, 2023

Conversation

dk1a
Copy link
Contributor

@dk1a dk1a commented Sep 18, 2023

fixes #1536

@changeset-bot
Copy link

changeset-bot bot commented Sep 18, 2023

🦋 Changeset detected

Latest commit: 23f02c4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 29 packages
Name Type
@latticexyz/store Major
@latticexyz/cli Major
@latticexyz/dev-tools Major
@latticexyz/react Major
@latticexyz/store-indexer Major
@latticexyz/store-sync Major
@latticexyz/world Major
@latticexyz/abi-ts Major
@latticexyz/block-logs-stream Major
@latticexyz/common Major
@latticexyz/config Major
create-mud Major
@latticexyz/ecs-browser Major
@latticexyz/faucet Major
@latticexyz/gas-report Major
@latticexyz/network Major
@latticexyz/noise Major
@latticexyz/phaserx Major
@latticexyz/protocol-parser Major
@latticexyz/recs Major
@latticexyz/schema-type Major
@latticexyz/services Major
@latticexyz/solecs Major
solhint-config-mud Major
solhint-plugin-mud Major
@latticexyz/std-client Major
@latticexyz/std-contracts Major
@latticexyz/store-cache Major
@latticexyz/utils Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dk1a dk1a marked this pull request as ready for review September 19, 2023 21:08
@dk1a dk1a requested review from holic and alvrs as code owners September 19, 2023 21:08
@holic
Copy link
Member

holic commented Sep 19, 2023

was this meant to be an improvement on gas or stack size?

@dk1a
Copy link
Contributor Author

dk1a commented Sep 20, 2023

was this meant to be an improvement on gas or stack size?

stack size, tho gas might be slightly improved too,
we don't have tests for gas here (doesn't really seem like an important difference)

@alvrs alvrs merged commit 80dd699 into main Sep 21, 2023
@alvrs alvrs deleted the dk1a/optimize-struct branch September 21, 2023 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider making tablegen's struct setters first class citizens instead of calling variable setters
3 participants