Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider making tablegen's struct setters first class citizens instead of calling variable setters #1536

Closed
alvrs opened this issue Sep 18, 2023 · 0 comments · Fixed by #1542
Closed

Consider making tablegen's struct setters first class citizens instead of calling variable setters #1536

alvrs opened this issue Sep 18, 2023 · 0 comments · Fixed by #1542
Assignees
@dk1a
Milestone
v2 contracts stable

Comments

@alvrs
Copy link
Member

alvrs commented Sep 18, 2023 •
edited
Loading

Context in https://github.com/latticexyz/mud/pull/1532/files#r1328697853
@alvrs alvrs converted this from a draft issue Sep 18, 2023
@alvrs alvrs added this to the Contracts stable milestone Sep 18, 2023
This was referenced Sep 18, 2023
Merged
Closed
@alvrs alvrs moved this from Planned to Next up in MUD v2 stable release (deprecated) Sep 18, 2023
@dk1a dk1a mentioned this issue Sep 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dk1a dk1a

Labels
None yet
Projects
No open projects
MUD v2 stable release (deprecated)
Status: Done
Milestone
v2 contracts stable
Development

Successfully merging a pull request may close this issue.

refactor(store): inline logic in codegenned set method which uses struct latticexyz/mud
2 participants
@dk1a @alvrs