Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(store): align Store event names between IStoreWrite and StoreCore #1237

Merged
merged 2 commits into from
Aug 3, 2023

Conversation

alvrs
Copy link
Member

@alvrs alvrs commented Aug 3, 2023

  • StoreCore had tableId while IStoreWrite had table, which created two entries in the generated ABI and caused a duplicate definition warning
  • A nicer solution for this would be to only declare these events once and emit them in StoreCore as IStoreWrite.StoreSetRecord, but this is only supported from Solidity version 0.8.21 (see Allow qualified access to events from other contracts ethereum/solidity#14274) and updating the Solidity version is a slightly bigger change than this quick fix

@alvrs alvrs requested a review from holic as a code owner August 3, 2023 17:44
@changeset-bot
Copy link

changeset-bot bot commented Aug 3, 2023

🦋 Changeset detected

Latest commit: e0d822a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 27 packages
Name Type
@latticexyz/store Patch
@latticexyz/cli Patch
@latticexyz/network Patch
@latticexyz/react Patch
@latticexyz/std-client Patch
@latticexyz/store-cache Patch
@latticexyz/store-indexer Patch
@latticexyz/store-sync Patch
@latticexyz/world Patch
@latticexyz/dev-tools Patch
@latticexyz/ecs-browser Patch
@latticexyz/block-logs-stream Patch
@latticexyz/common Patch
@latticexyz/config Patch
create-mud Patch
@latticexyz/gas-report Patch
@latticexyz/noise Patch
@latticexyz/phaserx Patch
@latticexyz/protocol-parser Patch
@latticexyz/recs Patch
@latticexyz/schema-type Patch
@latticexyz/services Patch
@latticexyz/solecs Patch
solhint-config-mud Patch
solhint-plugin-mud Patch
@latticexyz/std-contracts Patch
@latticexyz/utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@holic holic merged commit 5c965a9 into main Aug 3, 2023
@holic holic deleted the alvrs/update-store-abi branch August 3, 2023 18:10
@github-actions github-actions bot mentioned this pull request Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants