Allow qualified access to events from other contracts #14274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikola-matic
force-pushed
the
enable-access-to-foreign-events
branch
from
1349620 to
bb6aad2
Compare
nikola-matic
force-pushed
the
enable-access-to-foreign-events
branch
from
bb6aad2 to
5893e09
Compare
cameel
approved these changes
May 26, 2023
There was a problem hiding this comment.
The original commit this is based on was a bit lacking in terms of testing:
- The new cases are not covered by tests for Natspec, AST and ABI (see Export all events #10996).
- We should probably add semantic tests for the new cases now that the syntax tests are not failing.
But I guess if we accepted it back then, it won't hurt to approve this as is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13928
Fixes #14206