feat(block-logs-stream): add block logs stream package #1070
Conversation
🦋 Changeset detectedLatest commit: 4891d89 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
holic
force-pushed
the
holic/block-sync-package
branch
from
d739e85 to
093a852
Compare
holic
force-pushed
the
holic/block-sync-package
branch
from
093a852 to
ca31d48
Compare
holic
changed the title
holic
changed the title
holic
force-pushed
the
holic/block-sync-package
branch
from
748f33c to
1b417fa
Compare
holic
force-pushed
the
holic/block-sync-package
branch
from
704cb3b to
51a7be0
Compare
This reverts commit 1952a98.
| events, | ||
| }), | ||
| map(({ logs }) => from(groupLogsByBlockNumber(logs))), | ||
| mergeAll() |
There was a problem hiding this comment.
should we add import { mergeAll } from "rxjs" for this example?
There was a problem hiding this comment.
also what's the difference between map + mergeAll to mergeMap?
There was a problem hiding this comment.
no real difference! just got here iteratively, can do mergeMap instead
| publicClient, | ||
| address, | ||
| events, |
There was a problem hiding this comment.
is it worth adding the definitions of these to the example? or a comment about how to define them?
| FetchLogsResult<TAbiEvents> | ||
| >; | ||
|
|
||
| export function blockRangeToLogs<TAbiEvents extends readonly AbiEvent[]>({ |
There was a problem hiding this comment.
should we add a code documentation comment above here that explains the purpose / behavior?
Co-authored-by: alvarius <[email protected]>
|
just merged #1036 - can we add a changeset to this PR to try out the new release pipeline? |
holic
changed the title
pulled out of #1033